-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Fix List block's e2e test #28286
Merged
cameronvoell
merged 15 commits into
WordPress:master
from
fluiddot:rnmobile/fix/e2e-list-block
Jan 18, 2021
Merged
[RNMobile] Fix List block's e2e test #28286
cameronvoell
merged 15 commits into
WordPress:master
from
fluiddot:rnmobile/fix/e2e-list-block
Jan 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `master` branch from original repo.
Update master branch from original repo
Update master branch from original repo.
Update master branch from original repo
Update master branch from original repo.
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
Update master branch from original repo
The title for this button has changed so we have to update the value in the e2e tests.
Merged
2 tasks
hypest
reviewed
Jan 18, 2021
cameronvoell
approved these changes
Jan 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via wordpress-mobile/gutenberg-mobile#3014 (review) . CI is now passing for gb-mobile. Thanks for the fix @fluiddot !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobile
PR: wordpress-mobile/gutenberg-mobile#3014Description
Native e2e tests use the title prop of toolbar buttons as the ID for querying them in Appium, in a recent PR the value of
Convert to ordered list
button was changed and so the test is failing because it can't find the element.Appium error:
Since the value changed the fix has only implied to update the value.
How has this been tested?
This PR can be tested by running the List block's native e2e test for each platform:
cd packages/react-native-editor
npm run test:e2e:android:local gutenberg-editor-lists-@canary
npm run test:e2e:ios:local gutenberg-editor-lists-@canary
For more information about running e2e tests, check UI tests instructions (aka e2e tests).
Screenshots
iOS:

Android:

Types of changes
Bug fix
Checklist: